Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already support Emotion + Add note about styled-jsx and Stiches #108

Merged
merged 1 commit into from
May 10, 2022

Conversation

nvh95
Copy link
Owner

@nvh95 nvh95 commented May 10, 2022

Chores

  • Update docs to point out that we already support Emotion
  • Add comments and note about styled-jsx works partially accidentally, thanks to its syntax. But since styled-jsx/babel is not setup in Jest (yet), those css don't get transformed
  • Add a note that Stiches uses Constructable Stylesheet Objects, which does not present the CSS in head directly. So Jest Preview cannot preview the styles.

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for jest-preview-library ready!

Name Link
🔨 Latest commit ff6e307
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-library/deploys/627a85057e3c620009b1d5d0
😎 Deploy Preview https://deploy-preview-108--jest-preview-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nvh95 nvh95 changed the title feat: Support Emotion already + Add note about styled-jsx and stiches Already support Emotion + Add note about styled-jsx and Stiches May 10, 2022
@nvh95 nvh95 merged commit 8e08f92 into main May 10, 2022
@nvh95 nvh95 deleted the more-css-in-js-support branch May 10, 2022 15:32
@nvh95 nvh95 mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant